Implementation hide Roles and Permissions in menu when with viewAny. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But this required implementation creates RolePolicy and PermissionPolicy. These policies should be created in framework or by implementation? |
|
Hello @fbrissi Thanks for improving the package. Going to merge this in as soon as I decide whether there should be a RolePolicy and PermissionPolicy in the Package. Regards |
|
@bajramemini if you do not plan to merge this PR. Perhaps I can include a documentation for others to implment it themselves should they choose to. |
akiyamaSM
approved these changes
Apr 26, 2019
bajramemini
added a commit
that referenced
this pull request
Jul 5, 2019
Revert changes from Pull Request #4 because it caused the tool not to work properly without Gates/Policies. It only hides the tool and does not protect the routes/resources fully. Fixes #9 and resolves the need to add `vyuldashev/nova-permission` for the Gates/Policies #18. Will think about hiding Resources in the future, but added a note to the readme to hide the tool with the `canSee` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, when you create policy for roles and permission, both are not hidden.
Added
@canforviewAnyto hide when no has access.